Skip to content

[TypeDeclaration] Skip parent __call() exists on KnownMagicClassMethodTypeRector#7420

Merged
samsonasik merged 4 commits intomainfrom
skip-parent-exists
Oct 4, 2025
Merged

[TypeDeclaration] Skip parent __call() exists on KnownMagicClassMethodTypeRector#7420
samsonasik merged 4 commits intomainfrom
skip-parent-exists

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Oct 4, 2025

ref #7419 (review)
ref https://3v4l.org/f9vgb

When parent method exists, it cause error

Fatal error: Declaration of SomeClass::__call(string $method, array $args) must be compatible with SomeAbstract::__call($method, $args) in /in/f9vgb on line 12

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @TomasVotruba

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik enabled auto-merge (squash) October 4, 2025 16:47
@samsonasik samsonasik merged commit a3d2df1 into main Oct 4, 2025
49 of 50 checks passed
@samsonasik samsonasik deleted the skip-parent-exists branch October 4, 2025 16:48
@TomasVotruba
Copy link
Member

LGTM 👍

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants